Switch to passing the vmctx hidden argument at the beginning. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches to passing the vmctx hidden argument at the beginning of the argument list, rather than the end.
howjmay
pushed a commit
to howjmay/wasmtime
that referenced
this pull request
Jan 24, 2022
Summary: This creates an example based on the [WASI-tutorial](https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md#web-assembly-text-example) to illustrate how to enable WASI imports.
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 12, 2023
* Use `use` imports consistently. * Rename `flags_from_descriptor_flags` to `descriptor_flags_from_flags`. * Rename `black_box` to `obscure`. * Make some comments be doc comments. * Use a hyphen for compound adjectives. * Delete an unused variable. * Update the name of `change-file-permissions-at`. * Use generated typedefs instead of hard-coding u64. * Use core::hint::black_box now that it's stabilized.
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 16, 2023
* Use `use` imports consistently. * Rename `flags_from_descriptor_flags` to `descriptor_flags_from_flags`. * Rename `black_box` to `obscure`. * Make some comments be doc comments. * Use a hyphen for compound adjectives. * Delete an unused variable. * Update the name of `change-file-permissions-at`. * Use generated typedefs instead of hard-coding u64. * Use core::hint::black_box now that it's stabilized.
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Jul 15, 2023
…eatures (bytecodealliance#49) This patch pins `wat` and `wasmprinter` to our fork of `wasm-tools`.
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Dec 20, 2023
zkASM has no limitations on the bit-width of the immediates, so there is no value in keeping any of this logic, even as a reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to passing the vmctx hidden argument at the beginning of
the argument list, rather than the end.