Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-parallel-compilation CLI flag #4911

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Add --disable-parallel-compilation CLI flag #4911

merged 1 commit into from
Sep 16, 2022

Conversation

TerrorJack
Copy link
Contributor

Closes #4910. This PR adds --disable-parallel-compilation CLI flag to wasmtime, for use cases when parallel compilation is not desirable.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Parallel is a compile-time-conditional feature as well which is why the CI is failing here since the parallel compliation in the cli-flags crate is disabled when the crate is built in isolation. The feature is enabled by default in wasmtime and wasmtime-cli, however.

To fix the issue you'll want to add a parallel-compilation flag to the cli-flags crate and additionally enable the feature in the wasmtime-cli crate when the wasmtime-cli crate's parallel-compilation feature is enabled.

@TerrorJack
Copy link
Contributor Author

@alexcrichton Thanks for the suggestion! CI now passes, given my added code in cli-flags crate touches the parallel_compilation config field anyway, I've simply added wasmtime/parallel-compilation to cli-flag crate's default features.

@alexcrichton alexcrichton merged commit f558095 into bytecodealliance:main Sep 16, 2022
@TerrorJack TerrorJack deleted the cli-support-disable-parallel-compilation branch September 16, 2022 19:11
afonso360 pushed a commit to afonso360/wasmtime that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI/config option to disable parallel_compilation
2 participants