Initial work to build for Windows ARM64 #4990
Conversation
There was a problem hiding this comment.
Thanks, LGTM with a comment added as noted below!
For anyone seeing this, a note: we've found that Wasmtime doesn't yet handle Wasm traps properly on Windows/aarch64, which is why we aren't adding full builds here. If anyone is interested in working on this, I'm happy to point out the right areas at least, and review a PR. If/when that issue is resolved, if the Wasm testsuite passes, then this platform can graduate to tier 3 with build artifacts.
| @@ -183,6 +183,18 @@ jobs: | |||
| - run: cargo check --target wasm32-unknown-emscripten -p wasi-common | |||
| - run: cargo check --target armv7-unknown-linux-gnueabihf -p wasi-common | |||
|
|
|||
| # Check whether `wasmtime` cross-compiles to aarch64-pc-windows-msvc | |||
There was a problem hiding this comment.
Can we add a note here, with a link to the open issue, noting that Wasmtime is known to have issues on this platform (trap handling) and this is why it doesn't have a build with artifacts?
There was a problem hiding this comment.
OK. I've opened a new issue to track the trap handling on Windows ARM64, and added the link.
Minor thing I noticed from bytecodealliance#4990 but I stylistically prefer to keep the `mod foo;` definitions canonicalized to one location to emphasize how multiple targets can use the same definition.
Minor thing I noticed from #4990 but I stylistically prefer to keep the `mod foo;` definitions canonicalized to one location to emphasize how multiple targets can use the same definition.
This is a PR to build wasmtime to Windows ARM64. According to @kpreisser on #4435 , it should work without traps.
Fixes #4435
Check list
aarch64-pc-windows-msvc#4435description becomes long, the matter should probably be discussed in an issue
first.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.