winch: Adding support for integration tests #5588
Conversation
KevinRizzoTO
force-pushed
the
winch-golden-tests
branch
from
6bbb803 to
21257de
Compare
There was a problem hiding this comment.
I'm wondering if we should tweak a bit the directory structure of the test files? I'm thinking that we'd want to have multiple files per supported architecture: e.g. filetests/x64/simple.wat and filetests/aarch64/simple.wat, if we don't do this we'd probably end up with files named as simple_x64.wat
github-actions
bot
added
the
cranelift
KevinRizzoTO
force-pushed
the
winch-golden-tests
branch
from
21257de to
a8c5ffb
Compare
Maybe a glob-type pattern would make more sense here! So look for all |
KevinRizzoTO
force-pushed
the
winch-golden-tests
branch
from
a8c5ffb to
3169657
Compare
Agreed. Poor wording on my end, but I meant how we handle the directory structure of the filetests; the outcome that I expect is what you described. |
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
KevinRizzoTO
force-pushed
the
winch-golden-tests
branch
2 times, most recently
from
9931b88 to
0da42be
Compare
This commit adds two new crates into the Winch workspace: `filetests` and `test-macros`. The intent is to mimic the structure of Cranelift `filetests`, but in a simpler way.
This commits adds a high level document to outline how to test Winch through the `winch-tools` utility. It also updates some inline documentation which gets propagated to the CLI.
KevinRizzoTO
force-pushed
the
winch-golden-tests
branch
from
0da42be to
74dc244
Compare
As discussed on our call, this PR adds support for integration tests to Winch in the style of the Cranelift
filetests(for WAT). For information on how these work I've added documentation in thewinch/docsfolder here. There are still some features missing that we are going to add as we continue the project, like support for sending shared flags through the test configuration. Winch doesn't use these currently so it's been omitted to keep this PR smaller.I also took this as an opportunity to consolidate some dependencies into the top level
Cargo.toml. Some dependencies used by Cranelift were needed for the Winch tests, so I wanted to make sure the version would be consistent and consolidated to a single location.