Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the spec test suite submodule #5970

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Update the spec test suite submodule #5970

merged 2 commits into from
Mar 10, 2023

Conversation

alexcrichton
Copy link
Member

Delete the local copies of the relaxed-simd test suite as well as they're now incorporated.

Closes #5914

@alexcrichton
Update the spec test suite submodule
6239735 
Delete the local copies of the relaxed-simd test suite as well as
they're now incorporated.

Closes bytecodealliance#5914
@alexcrichton alexcrichton added this pull request to the merge queue Mar 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2023
@alexcrichton alexcrichton added this pull request to the merge queue Mar 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2023
@alexcrichton
Remove page guards in QEMU emulation
1a62979 
Otherwise `(memory 0 0)` was being compiled as a static memory with huge
guards which we're trying to avoid in QEMU.
@alexcrichton
Copy link
Member Author

The test failures here I think are due to OOM for QEMU taking too much memory. After some investigation I found out that some of the new multi-memory tests add a few (memory 0 0) to modules to test when the memory index isn't 0 (and the "main memory" is somewhere in the middle of the index space. These 0-sized 0-max-size memories, however, were getting compiled as static memories (the "maximum size" is 0 after all) which meant they got static memory guards which was 4G of virtual memory which is a known way to get QEMU to OOM.

I've updated the test suite so that when under QEMU emulation we not only force dynamic memories but additionally all guards are removed. This further drastically reduces the virtual memory footprint, as intended, when under emulation and I think should make this landable.

FWIW running the spec tests in QEMU on my local machine took 1.3G max RSS prior and now it takes 250M so hopefully a nice improvement!

@alexcrichton alexcrichton enabled auto-merge March 10, 2023 16:33
alexcrichton added a commit to alexcrichton/wasmtime that referenced this pull request Mar 10, 2023
@alexcrichton
Add a --dynamic-memory-reserved-for-growth CLI flag
26be350 
Maps to the corresponding `wasmtime::Config` option. The motivation here
is largely completeness and was something I was looking into with the
failures in bytecodealliance#5970
@alexcrichton alexcrichton mentioned this pull request Mar 10, 2023
Merged
@alexcrichton alexcrichton added this pull request to the merge queue Mar 10, 2023
Merged via the queue into bytecodealliance:main with commit 7650d85 Mar 10, 2023
@alexcrichton alexcrichton deleted the update-testsuite branch March 10, 2023 17:30
alexcrichton added a commit that referenced this pull request Mar 10, 2023
@alexcrichton
Add a --dynamic-memory-reserved-for-growth CLI flag (#5980)
0751cba 
Maps to the corresponding `wasmtime::Config` option. The motivation here
is largely completeness and was something I was looking into with the
failures in #5970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchickey pchickey pchickey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove local copies of the relaxed-simd test suite
2 participants
@alexcrichton @pchickey