perf: Create a per-process JIT dump file #6024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
alexcrichton
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create a new
JitDumpAgentperwasmtime::Engine,, and the former creates a new jit dump file in its constructor. Since the jit dump file name has to be unique and must follow the format expected byperf inject, the file name is a constant. This causes a bug that multipleEngines creations will clobber the jit dump file. Because of the file name requirement, we can't simply add a counter suffix in the jit dump file name, because thenperf injectwouldn't find the files anymore.Instead, we can use a single, per-process JIT dump file, that's shared across all the
wasmtime::Engine; this works well in practice, and moves the mutex inJitDumpAgentin the outside world.