ISLE: rewrite loose inequalities to strict inequalities and strict inequalities to equalities #6130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cranelift
Kmeakin
changed the title
Kmeakin
force-pushed
the
icmp-loose-inequalities-to-strict-inequalities
branch
2 times, most recently
from
20ac67e
to
9e31ec1
Compare
Kmeakin
force-pushed
the
icmp-loose-inequalities-to-strict-inequalities
branch
from
9e31ec1
to
0507a1d
Compare
cfallin
approved these changes
Apr 4, 2023
cfallin
added a commit
to cfallin/wasmtime
that referenced
this pull request
Apr 10, 2023
…trict inequalities to equalities (bytecodealliance#6130)" This reverts commit 57e42d0. Fixes bytecodealliance#6185.
cfallin
added a commit
to cfallin/wasmtime
that referenced
this pull request
Apr 10, 2023
…trict inequalities to equalities (bytecodealliance#6130)" This reverts commit 57e42d0. Fixes bytecodealliance#6185.
cfallin
added a commit
that referenced
this pull request
Apr 10, 2023
cfallin
added a commit
that referenced
this pull request
Apr 10, 2023
brendandburns
pushed a commit
to brendandburns/wasmtime
that referenced
this pull request
Apr 13, 2023
…trict inequalities to equalities (bytecodealliance#6130)" (bytecodealliance#6193) This reverts commit 57e42d0. Fixes bytecodealliance#6185.
Kmeakin
added a commit
to Kmeakin/wasmtime
that referenced
this pull request
Jul 27, 2024
Add a regression test for issue bytecodealliance#6185. PR bytecodealliance#6130 will be re-applied in next commit. Signed-off-by: Karl Meakin <karl.meakin@arm.com>
Kmeakin
added a commit
to Kmeakin/wasmtime
that referenced
this pull request
Jul 27, 2024
Add a regression test for issue bytecodealliance#6185. PR bytecodealliance#6130 will be re-applied in next commit. Signed-off-by: Karl Meakin <karl.meakin@arm.com>
Kmeakin
added a commit
to Kmeakin/wasmtime
that referenced
this pull request
Jul 27, 2024
Add a regression test for issue bytecodealliance#6185. PR bytecodealliance#6130 will be re-applied in next commit. Copyright (c) 2024, Arm Limited. Signed-off-by: Karl Meakin <karl.meakin@arm.com>
Kmeakin
added a commit
to Kmeakin/wasmtime
that referenced
this pull request
Jul 29, 2024
Add a regression test for issue bytecodealliance#6185. PR bytecodealliance#6130 will be re-applied in next commit. Copyright (c) 2024, Arm Limited. Signed-off-by: Karl Meakin <karl.meakin@arm.com>
Kmeakin
added a commit
to Kmeakin/wasmtime
that referenced
this pull request
Aug 5, 2024
Add a regression test for issue bytecodealliance#6185. PR bytecodealliance#6130 will be re-applied in next commit. Copyright (c) 2024, Arm Limited. Signed-off-by: Karl Meakin <karl.meakin@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites loose inequalities against constants to equivalent strict inequalities, and strict inequalities to equalities when possible. By itself not more efficient, but should expose more CSE opportunities (eg
ule x, 2 && ult x, 1)