Update doc for which integer types are supported #6233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameysharp
reviewed
Apr 18, 2023
cranelift/docs/ir.md
Outdated
| The function `valid_for_target` within the [fuzzgen function generator][fungen] | ||
| contains information about which instructions support which types. | ||
|
|
||
| [fungen]: https://github.com/elliottt/wasmtime/blob/545749b279974e87bfceada10f5f301f4503e4ce/cranelift/fuzzgen/src/function_generator.rs#L310 |
There was a problem hiding this comment.
This text is great, but I'm not sure we should use this link. At the least, I think we should link to mainline Wasmtime rather than Trevor's fork.
Also maybe we should link to whatever is on main, rather than a specific commit. Then we can't reliably link to the specific function, but just giving the function name is probably good enough.
So I think linking to https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/fuzzgen/src/function_generator.rs would be best here.
github-actions
bot
added
cranelift
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Apr 28, 2023
* Update doc for which integer types are supported * Update ir.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps coming up on Zulip, so proposing some new text.
This is a documentation-only change.