Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump regalloc2 #6398

Merged
merged 2 commits into from
May 17, 2023
Merged

Conversation

elliottt
Copy link
Member

Bump the regalloc2 dependency to 0.9.0, to pull in some new perf improvements.

@elliottt elliottt requested a review from a team as a code owner May 17, 2023 16:36
@elliottt elliottt requested review from abrown and removed request for a team May 17, 2023 16:36
@elliottt elliottt requested a review from a team as a code owner May 17, 2023 16:48
Comment on lines +1708 to +1715
; movq %rdx, %r11
; movq %rdi, %r8
; shrq %cl, %r8
; movq %rsi, %r10
; shrq %cl, %r10
; movq %rcx, %r11
; movl $0x40, %ecx
; movq %rdx, %rdi
; movq %r11, %rdi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional moves here are expected, as we're now creating overlapping liveranges in regalloc2-0.9.0. Follow-on work will involve removing these, but local profiling of benchmarks like bz2, pulldown-cmark, and spidermonkey was not showing any performance regression.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited to have this! A few extra moves are OK for now, as you say, since we know where they come from and how to address them, and overall this is a quite good compile-time win.

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label May 17, 2023
@elliottt elliottt force-pushed the trevor/regalloc2-0.9.0 branch from 6438a7c to 2caf68a Compare May 17, 2023 21:29
@elliottt elliottt force-pushed the trevor/regalloc2-0.9.0 branch from 2caf68a to 974ddb5 Compare May 17, 2023 21:30
@elliottt elliottt added this pull request to the merge queue May 17, 2023
Merged via the queue into bytecodealliance:main with commit c1d0508 May 17, 2023
@elliottt elliottt deleted the trevor/regalloc2-0.9.0 branch May 17, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants