-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump regalloc2 #6398
Bump regalloc2 #6398
Conversation
; movq %rdx, %r11 | ||
; movq %rdi, %r8 | ||
; shrq %cl, %r8 | ||
; movq %rsi, %r10 | ||
; shrq %cl, %r10 | ||
; movq %rcx, %r11 | ||
; movl $0x40, %ecx | ||
; movq %rdx, %rdi | ||
; movq %r11, %rdi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional moves here are expected, as we're now creating overlapping liveranges in regalloc2-0.9.0. Follow-on work will involve removing these, but local profiling of benchmarks like bz2, pulldown-cmark, and spidermonkey was not showing any performance regression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excited to have this! A few extra moves are OK for now, as you say, since we know where they come from and how to address them, and overall this is a quite good compile-time win.
6438a7c
to
2caf68a
Compare
2caf68a
to
974ddb5
Compare
Bump the regalloc2 dependency to 0.9.0, to pull in some new perf improvements.