Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Config::static_memory_forced to C #6413

Conversation

agutekanst-llnw
Copy link
Contributor

This change exposes the static_memory_forced configuration method to C. This matches other methods of the Config struct.

I don't believe an issue is needed here as this change is so small, but if you feel otherwise please let me know and I'd be happy to create an issue first 😄 .

@agutekanst-llnw agutekanst-llnw requested a review from a team as a code owner May 18, 2023 19:03
@agutekanst-llnw agutekanst-llnw requested review from pchickey and removed request for a team May 18, 2023 19:03
@agutekanst-llnw agutekanst-llnw changed the title Expose static_memory_forced to C Expose Config::static_memory_forced to C May 18, 2023
Copy link
Contributor

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@github-actions github-actions bot added the wasmtime:c-api Issues pertaining to the C API. label May 18, 2023
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton
Copy link
Member

Could you also update the config.h header file for this new option?

@agutekanst-llnw
Copy link
Contributor Author

Ah, sorry about that. I'll update that in just a moment.

(I accidentally updated it in my local copy of the wasmtime-cpp repo, rather than in the wasmtime source-of-truth 😓 )

@alexcrichton alexcrichton added this pull request to the merge queue May 19, 2023
Merged via the queue into bytecodealliance:main with commit e933c7e May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants