Fix flaky tests in preview2 streams #6763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't realize this test was racy, but it makes sense because the worker is consuming these writes in another thread. usually the foreground thread wins, but we observed the other case once in CI
alexcrichton
approved these changes
Jul 24, 2023
I made a typo translating the sync calls to async calls, and in the sync implementation stream::blocking_write was calling async stream::write, so it was missing the logic to make the write blocking. This would in turn cause panics in rust's std::io::stdio::print_to when writes return less than the length of the input. thank you to @silentbicycle for autoclave, which we used to reproduce this bug.
pchickey
force-pushed
the
pch/preview2_streams_flaky_tests
branch
from
aa52d22 to
2afbede
Compare
|
Yanked from the merge queue because we found the bug, so instead of ignoring the test the bug is now fixed. |
elliottt
approved these changes
Jul 24, 2023
geekbeast
pushed a commit
to geekbeast/wasmtime
that referenced
this pull request
Aug 1, 2023
* main: (47 commits) Add core dump support to the runtime (bytecodealliance#6513) Resource table tracks child relationships (bytecodealliance#6779) Wasmtime: Move `OnDemandInstanceAllocator` to its own module (bytecodealliance#6790) wasi: Test the stdio streams implementation (bytecodealliance#6764) Don't generate same-named imports in fact modules (bytecodealliance#6783) Wasmtime: Add support for Wasm tail calls (bytecodealliance#6774) Cranelift: Fix `ABIMachineSpec::gen_add_imm` for riscv64 (bytecodealliance#6780) Update the wasm-tools family of crates, disallow empty component types (bytecodealliance#6777) Fix broken link to WASI API documentation (bytecodealliance#6775) A bunch of cleanups for cranelift-codegen-meta (bytecodealliance#6772) Implement component-to-component calls with resources (bytecodealliance#6769) Ignore async_stack_size if async_support is disabled (bytecodealliance#6771) A bunch of minor cleanups (bytecodealliance#6767) Fix flaky tests in preview2 streams (bytecodealliance#6763) Refactor and simplify component trampolines (bytecodealliance#6751) Cranelift: Implement tail calls on riscv64 (bytecodealliance#6749) WASI Preview 2: rewrite streams and pollable implementation (bytecodealliance#6556) cranelift-wasm: Add support for translating Wasm tail calls to CLIF (bytecodealliance#6760) Cranelift: Get tail calls working on aarch64 (bytecodealliance#6723) Implement component model resources in Wasmtime (bytecodealliance#6691) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6556 introduced (at least) 2 flaky tests:
sink_write_streamtest in pipes. This test has been fixed, and the comment describes the race.poll_oneoff_stdiois failed nondeterministically in thewasi-preview2-components-syncsuite. We found a typo in the sync-to-async translation that caused this bug.Thanks @silentbicycle, we used autoclave to reproduce this after a few hundred iterations: