wasi-cap-std-sync: use std::io::Std{in,out,err} to impl {read,write}_vectored #6825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just had to remember this: to get all the tests to run, add |
pchickey
force-pushed
the
pch/wasi_unicode_stdout
branch
from
a51c646
to
f2297a9
Compare
added 2 commits
September 12, 2023 13:57
there's not yet a way to show this test is actually doing what we intend, I'm using CI to see how this runs on all platforms Reported in #6824 prtest:full
…rectly instead of using AsFilelike to view these as a File. This means we also have to use std's mutexes to access these descriptors, which also seems like a good idea. We believe will fix unicode output on windows issues: #6824
pchickey
force-pushed
the
pch/wasi_unicode_stdout
branch
from
f2297a9
to
5089c09
Compare
pchickey
changed the title
alexcrichton
approved these changes
Sep 12, 2023
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 13, 2023
…vectored (bytecodealliance#6825) * add new wasi-test printing unicode on stdout there's not yet a way to show this test is actually doing what we intend, I'm using CI to see how this runs on all platforms Reported in bytecodealliance#6824 prtest:full * cap-std-sync: use std::io::Std{in,out,err}'s {read,write}_vectored directly instead of using AsFilelike to view these as a File. This means we also have to use std's mutexes to access these descriptors, which also seems like a good idea. We believe will fix unicode output on windows issues: bytecodealliance#6824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #6824.
Unfortunately it does not appear that CI reproduces the behavior of an actual windows cmd.exe, so we'll need a windows user to test it manually to verify.