riscv64: Check that the minimum set of feature flags is enabled #6975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds descriptions to some existing flags
afonso360
added
the
cranelift:area:riscv64
bjorn3
reviewed
Sep 7, 2023
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
alexcrichton
approved these changes
Sep 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Let's see just how transient that failure is |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions
bot
added
cranelift
alexcrichton
pushed a commit
that referenced
this pull request
Sep 12, 2023
* riscv64: Add G extension predicate Also adds descriptions to some existing flags * riscv64: Restrict creating a backend without base features * riscv64: Clarify INSTRUCTION_SIZE constant * riscv64: Update wording on ISA flag error Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com> * riscv64: Run rustfmt --------- Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 13, 2023
…codealliance#6975) * riscv64: Add G extension predicate Also adds descriptions to some existing flags * riscv64: Restrict creating a backend without base features * riscv64: Clarify INSTRUCTION_SIZE constant * riscv64: Update wording on ISA flag error Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com> * riscv64: Run rustfmt --------- Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR Is a follow up to #6955 where @alexcrichton suggested that we check that all the flags the backend currently expects.
Most of the backend does not even check these flags, so to avoid emitting instructions where there is no support for them, we reject building the ISA when they aren't present.
This PR also renames the
INSTRUCTION_SIZEconstant to something more suitable, since we are going to have varying instruction lengths.