Implement support for exported resources in bindgen!
#7050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `wasmtime::component::bindgen!` to support exported resources. Exported resources are themselves always modeled as `ResourceAny` at runtime and are required to perform dynamic type checks to ensure that the right type of resource is passed in. Exported resources have their own `GuestXXX` structure exported to namespace all of their methods. Otherwise, like imports, there's not a whole lot of special treatment of exported resources.
Looks like `to_snake_case` behaves differently if the `unicode` feature is enabled or not so bypass that entirely.
pchickey
approved these changes
Sep 15, 2023
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 22, 2023
…nce#7050) * Implement support for exported resources in `bindgen!` This commit updates the `wasmtime::component::bindgen!` to support exported resources. Exported resources are themselves always modeled as `ResourceAny` at runtime and are required to perform dynamic type checks to ensure that the right type of resource is passed in. Exported resources have their own `GuestXXX` structure exported to namespace all of their methods. Otherwise, like imports, there's not a whole lot of special treatment of exported resources. * Work around `heck` issue Looks like `to_snake_case` behaves differently if the `unicode` feature is enabled or not so bypass that entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
wasmtime::component::bindgen!to support exported resources. Exported resources are themselves always modeled asResourceAnyat runtime and are required to perform dynamic type checks to ensure that the right type of resource is passed in. Exported resources have their ownGuestXXXstructure exported to namespace all of their methods. Otherwise, like imports, there's not a whole lot of special treatment of exported resources.