-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c-api: Update reexport of wasmtime crate crate #7112
c-api: Update reexport of wasmtime crate crate #7112
Conversation
This is a follow-up to bytecodealliance#6765 to remove this reexport since it was originally added to use both the C API and the `wasmtime` crate in the same downstream crate, but this should be possible through Cargo with: [dependencies] wasmtime = "13" wasmtime-c-api = { version = "13", package = "wasmtime-c-api" } and that way `wasmtime::*` is available as well as `wasmtime_c_api::*`
cc @RubixDev and @maxbrunsfeld on this. I'd want to confirm that your embedding use case still works if this is removed. Additionally this is mostly just pointing out that it's not necessary to have this directive to get things working. That being said I can imagine it's still convenient to have because you'd only need one Cargo manifest directive instead of two. If y'all would prefer I think it would make sense to keep this but as |
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:c-api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
I like the idea of |
Ok sounds good to me, I've updated to remove just the |
ping @fitzgen, mind taking a look at this? |
This is a follow-up to #6765 to update this reexport since it was originally added to use both the C API and the
wasmtime
crate in the same downstream crate, but this should be possible through Cargo with:and that way
wasmtime::*
is available as well aswasmtime_c_api::*
. For convenience though the namewasmtime
is still exported to allow depending on just this crate.