Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor preview2 related test cleanups #7232

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Minor preview2 related test cleanups #7232

merged 2 commits into from
Oct 12, 2023

Conversation

pchickey
Copy link
Contributor

  • there was a duplicate test for the behavior of panics
  • the test for stream pollable children lifetimes was different than all of the others to invoke, so split it into two tests (in preview2 instead of cli) and assert that one of them traps, the other succceeds

Pat Hickey added 2 commits October 12, 2023 10:53
delete redundant cli test
9a85588 
cli_panic is almost exactly the same as cli_exit_panic, so delete the first one
split stream pollable lifetimes test into two preview2 tests
c6b4f03
@pchickey pchickey requested a review from a team as a code owner October 12, 2023 19:28
@pchickey pchickey requested review from fitzgen and elliottt and removed request for a team and fitzgen October 12, 2023 19:28
elliottt
elliottt approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pchickey pchickey added this pull request to the merge queue Oct 12, 2023
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Oct 12, 2023
Merged via the queue into main with commit 88bc013 Oct 12, 2023
@pchickey pchickey deleted the pch/minor_test_cleanups branch October 12, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

Assignees
No one assigned
Labels
wasi Issues pertaining to WASI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchickey @elliottt