riscv64: Refactor and improve some rotate-related codegen #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move from `inst.isle` to `lower.isle` since it's the only caller, reorganize the rules to be a bit cleaner, add immediate shifting specializations.
Same as the prior `rotl` lowerings, move the rules to `lower.isle` and additionally add constant rules.
fitzgen
approved these changes
Oct 16, 2023
Comment on lines
1225
to
1227
| ;; | ||
| (part1 Reg (rv_sll rs shamt)) | ||
| ;; |
There was a problem hiding this comment.
Don't shoot the messenger -- but yeah I'll go through and clean this up
github-actions
bot
added
the
cranelift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit expands the support a bit for zbb-extension rotates in the riscv64 backend. The lowering rules are all moved to
lower.isleand some special cases are added for constant rotates as well.