Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riscv64: Improve scalar_to_vector for constants #7284

Merged
merged 5 commits into from
Oct 19, 2023
Merged

riscv64: Improve scalar_to_vector for constants #7284

merged 5 commits into from
Oct 19, 2023

Conversation

BieVic
Copy link
Contributor

@BieVic BieVic commented Oct 18, 2023

This simple improvement adds a rule for the vmerge.vim instruction and an imm5_from_value extractor.
Closes #7189

@BieVic BieVic requested a review from a team as a code owner October 18, 2023 18:04
@BieVic BieVic requested review from cfallin and removed request for a team October 18, 2023 18:04
@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Oct 18, 2023
afonso360
afonso360 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@afonso360 afonso360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me 🎉 . Thanks for working on this!

Could you also add a run test over at cranelift/filetests/filetests/runtests/simd-scalartovector.clif so that this also gets tested that way in CI?

cranelift/codegen/src/isa/riscv64/inst.isle Outdated Show resolved Hide resolved
afonso360
afonso360 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@afonso360 afonso360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Thanks!

@afonso360 afonso360 enabled auto-merge October 19, 2023 15:41
@afonso360 afonso360 added this pull request to the merge queue Oct 19, 2023
Merged via the queue into bytecodealliance:main with commit 70039d8 Oct 19, 2023
@BieVic BieVic deleted the rv64-vmerge-vim branch October 26, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonso360 afonso360 afonso360 approved these changes

@cfallin cfallin Awaiting requested review from cfallin cfallin is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

riscv64: Improve scalar_to_vector codegen for constants
2 participants
@BieVic @afonso360