Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi-http: Return an optional trailers from future-trailers.get #7351

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

elliottt
Copy link
Member

@elliottt elliottt commented Oct 24, 2023

Avoid creating a new fields resource to represent the case where no trailers were present in an incoming-body by making the returned trailers optional. This mirrors the optional trailers parameter to outgoing-body.finish.

Fixes #7275

@elliottt elliottt requested a review from a team as a code owner October 24, 2023 16:52
@elliottt elliottt requested review from pchickey and removed request for a team October 24, 2023 16:52
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Oct 24, 2023
@elliottt elliottt added this pull request to the merge queue Oct 26, 2023
Merged via the queue into bytecodealliance:main with commit d36e2c1 Oct 26, 2023
@elliottt elliottt deleted the trevor/optional-trailers branch October 26, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasi Issues pertaining to WASI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasi-http: make methods that read trailers return optional results
2 participants