Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove filesystem locks #7355

Merged
merged 3 commits into from
Oct 26, 2023
Merged

remove filesystem locks #7355

merged 3 commits into from
Oct 26, 2023

Conversation

pchickey
Copy link
Contributor

Corresponds to WebAssembly/wasi-filesystem#136

We believe there is value in these lock methods for some applications
(e.g. sqlite), but for the sake of shipping Preview 2, we don't have
time to make and test a cross platform implementation of these in two
separate engines at this time. This is in part because some additional
design work is required to integrate the blocking lock functions with
pollable.

These functions may come back as part of an additional filesystem
interface in a post Preview 2 patch version 0.2.n, or in Preview 3 or
beyond. Until then, their design is still in the git history.

@pchickey pchickey requested a review from a team as a code owner October 25, 2023 00:21
@pchickey pchickey requested review from fitzgen and removed request for a team October 25, 2023 00:21
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Oct 25, 2023
@pchickey pchickey added this pull request to the merge queue Oct 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2023
@alexcrichton alexcrichton added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit 8a91ae7 Oct 26, 2023
20 checks passed
@alexcrichton alexcrichton deleted the pch/remove_filesystem_locks branch October 26, 2023 22:01
@alexcrichton alexcrichton mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
wasi Issues pertaining to WASI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchickey @alexcrichton