Fix file writes in preview 2 implementation #7394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
force-pushed
the
pch/preview2_large_writes
branch
from
adf9592 to
1fd1585
Compare
|
Should this be backported to 14.0.x as well? |
|
Yes. I was going to write more tests and I was chasing down some other potential improvements as well, but the bug here is obvious now, so I think we should just land this patch in main and in the next 14 release to go out. |
pchickey
changed the title
pchickey
changed the title
pchickey
requested review from
fitzgen and
alexcrichton
and removed request for
a team and
fitzgen
alexcrichton
approved these changes
Oct 31, 2023
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 31, 2023
* add a preview1_file_write test to show behavior of large file writes reproduces bytecodealliance#7390 * filesystem output-stream: update position cursor
alexcrichton
added a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7130, there was a regression introduced in FileOutputStream where the position cursor was not updated after each write. This affects all file writes except for when the file is opened for appending.
This PR also adds a test which performs a larger (64k) write to a file than any prior tests.
Fixes #7390