Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranelift: Reassociate long and narrow chains of operations into shallow and wide trees #7466

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Nov 2, 2023

This increases instruction-level parallelism and shrinks live ranges. It also
canonicalizes into the shallow-and-wide form for reassociating constants
together for cprop.

Depends on #7456

@fitzgen fitzgen requested a review from a team as a code owner November 2, 2023 21:57
@fitzgen fitzgen requested review from elliottt and removed request for a team November 2, 2023 21:57
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language labels Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

…low and wide trees

This increases instruction-level parallelism and shrinks live ranges. It also
canonicalizes into the shallow-and-wide form for reassociating constants
together for cprop.

Co-Authored-By: Chris Fallin <chris@cfallin.org>
Co-Authored-By: Trevor Elliott <telliott@fastly.com>
@fitzgen fitzgen enabled auto-merge November 8, 2023 00:06
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fitzgen fitzgen added this pull request to the merge queue Nov 8, 2023
Merged via the queue into bytecodealliance:main with commit 72534b0 Nov 8, 2023
18 checks passed
@fitzgen fitzgen deleted the shallow-and-wide branch November 8, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants