Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the compilation cache for components #7649

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

elliottt
Copy link
Member

@elliottt elliottt commented Dec 6, 2023

Cache whole components in the compilation cache. This doesn't address the situation where we could cache individual modules used within the component separately, and reuse those results across multiple components. However, it does improve the runtime of command-line uses of components today, and anecdotally people are benchmarking wasmtime run with components.

@elliottt elliottt requested a review from a team as a code owner December 6, 2023 18:59
@elliottt elliottt requested review from alexcrichton and removed request for a team December 6, 2023 18:59
Co-authored-by: Pat Hickey <pat@moreproductive.org>
@elliottt elliottt force-pushed the trevor/component-cli-caching branch from f106cfb to 1c53d7c Compare December 6, 2023 19:00
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Dec 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2023
@elliottt elliottt added this pull request to the merge queue Dec 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2023
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Dec 6, 2023
Copy link

github-actions bot commented Dec 6, 2023

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@elliottt elliottt added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit a18752c Dec 12, 2023
21 checks passed
@elliottt elliottt deleted the trevor/component-cli-caching branch December 12, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants