[17.0.0] Backport fix fd_read
and fd_write
for wasm32-wasi-threads
(#7750)
#7755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
first_non_empty_{c}io_vec
always returnedOk(None)
for buffers residing in shared memories since they cannot, in general, safely be represented as slices. That caused e.g.wasi-libc
to spin forever when trying to write to stdout usingfd_write
since it always gotOk(0)
and never made progress.This commit changes the return type of both functions to use
GuestPtr
instead ofGuestSlice{Mut}
, allowing safe access to shared guest memory.Big thanks to Alex Crichton for narrowing this down and suggesting the fix.