Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed broken link to polyfill #78

Closed

Conversation

ColinEberhardt
Copy link

No description provided.

@sunfishcode
Copy link
Member

Thanks for the PR! I happened to fixed these links before I saw this PR though, so they're already fixed in c37f245.

pchickey pushed a commit to pchickey/wasmtime that referenced this pull request May 12, 2023
…lliance#83)

* short-circuit reentrance when allocating stack and `State`

Per bytecodealliance/wasm-tools#919,
`wit-component` needs to lazily allocate the adapter stack to avoid
premature or infinite reentrance from the main module to the adapter.
This means adding an additional `allocation_state` global variable and
using it to determine when to return early from an exported function,
e.g. because we're in the process of either allocating the stack or
allocating `State`.

This requires an updated `wit-component` dependency once
bytecodealliance/wasm-tools#919 has been
merged.

Fixes bytecodealliance#78

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

* remove redundant unsafe blocks

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

* update dependencies

This brings us up-to-date with wasi-tools, wit-bindgen, and the latest
component ABI.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

---------

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
pchickey pushed a commit to pchickey/wasmtime that referenced this pull request May 16, 2023
…lliance#83)

* short-circuit reentrance when allocating stack and `State`

Per bytecodealliance/wasm-tools#919,
`wit-component` needs to lazily allocate the adapter stack to avoid
premature or infinite reentrance from the main module to the adapter.
This means adding an additional `allocation_state` global variable and
using it to determine when to return early from an exported function,
e.g. because we're in the process of either allocating the stack or
allocating `State`.

This requires an updated `wit-component` dependency once
bytecodealliance/wasm-tools#919 has been
merged.

Fixes bytecodealliance#78

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

* remove redundant unsafe blocks

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

* update dependencies

This brings us up-to-date with wasi-tools, wit-bindgen, and the latest
component ABI.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

---------

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
mooori pushed a commit to mooori/wasmtime that referenced this pull request Dec 20, 2023
dhil added a commit to dhil/wasmtime that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants