Close intermediate streams for reads/writes #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously temporary streams created as part of the preview1 adapter in the wasmtime-wasi crate were left open which meant that they continued to occupy space in the resource table and the underlying file accidentally wasn't ever actually closed. cc bytecodealliance#7813
pchickey
approved these changes
Jan 24, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 24, 2024
This commit takes a stab at bytecodealliance#7816 without diving a whole lot into it. I noticed that the loop started with `vcvtss2sd` which is along the same lines as previous false dependencies found earlier in PRs such as bytecodealliance#7098. I had forgotten these instructions at the time and meant to go back and touch them up and bytecodealliance#7731 has provided sufficient motivation to do so! Locally this takes that test case from 1.6s to 0.4s for me.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 25, 2024
Previously temporary streams created as part of the preview1 adapter in the wasmtime-wasi crate were left open which meant that they continued to occupy space in the resource table and the underlying file accidentally wasn't ever actually closed. cc bytecodealliance#7813
alexcrichton
added a commit
that referenced
this pull request
Jan 25, 2024
Previously temporary streams created as part of the preview1 adapter in the wasmtime-wasi crate were left open which meant that they continued to occupy space in the resource table and the underlying file accidentally wasn't ever actually closed. cc #7813
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Break more data dependencies in float-related instructions This commit takes a stab at #7816 without diving a whole lot into it. I noticed that the loop started with `vcvtss2sd` which is along the same lines as previous false dependencies found earlier in PRs such as #7098. I had forgotten these instructions at the time and meant to go back and touch them up and #7731 has provided sufficient motivation to do so! Locally this takes that test case from 1.6s to 0.4s for me. * Fix inst emit tests * Update winch codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously temporary streams created as part of the preview1 adapter in the wasmtime-wasi crate were left open which meant that they continued to occupy space in the resource table and the underlying file accidentally wasn't ever actually closed.
cc #7813