Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the behavior of some rights-related functions. #784

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

marmistrz
Copy link
Contributor

cf. #770

Copy link
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation changes make sense to me.

@marmistrz
Copy link
Contributor Author

Is there anything that prevents this PR from being merged?

@peterhuene
Copy link
Member

@marmistrz I think it's ready and I'll merge it now.

Sorry, it's a little hard for me to tell who has write access to the repo as I know @kubkon does and both of you show up as Collaborator. I generally try to avoid merging PRs from people with write access to avoid prematurely merging.

@peterhuene peterhuene merged commit c78bf3c into bytecodealliance:master Jan 23, 2020
arkpar pushed a commit to paritytech/wasmtime that referenced this pull request Mar 4, 2020
Only create copy_nop instructions for types for which an encoding exi…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants