Enable -Scommon by default for wasmtime serve
#8138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables more WASI interfaces by default with `wasmtime serve`, notably through the use of the `-Scommon` flag. This means that the interfaces supported by `wasmtime serve` are the same as `wasmtime run` by default. To fully implement this there's a number of refactorings here: * More flags like `--dir` and `--env` are moved into `RunCommon` to be shared between `wasmtime serve` and `wasmtime run`, meaning that the `serve` command can now configure environment variables. * A small test has been added as well as infrastructure for running tests with `wasmtime serve` itself. Previously there were no tests that executed `wasmtime serve`. * The `test_programs` crate had a small refactoring to avoid double-generation of http bindings. Closes bytecodealliance#8086
|
Thank you for doing this, and fully aligning it with |
alexcrichton
added a commit
to bytecodealliance/meetings
that referenced
this pull request
Mar 25, 2024
* bytecodealliance/wasmtime#8138 * Discussion of `cargo vet`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables more WASI interfaces by default with
wasmtime serve, notably through the use of the-Scommonflag. This means that the interfaces supported bywasmtime serveare the same aswasmtime runby default.To fully implement this there's a number of refactorings here:
More flags like
--dirand--envare moved intoRunCommonto be shared betweenwasmtime serveandwasmtime run, meaning that theservecommand can now configure environment variables.A small test has been added as well as infrastructure for running tests with
wasmtime serveitself. Previously there were no tests that executedwasmtime serve.The
test_programscrate had a small refactoring to avoid double-generation of http bindings.Closes #8086