Forward-port some release notes to main #8357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
wasmtime:docs
jameysharp
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
This does make main match the corresponding patch release notes. Those patch release notes were a bit off though and maybe we should at least fix them on main?
- Handle out-of-bounds component sections #8323 was a bugfix, not Panic in
wasmtime::component::Component::from_binarywith a truncated WASM component file #8322 which was the issue that it fixed, and it went out in 17.0.3 as well as the others but only made it into the release notes for v18 and v19. - [19.0.0] cranelift: Include clobbers and outgoing args in stack limit #8334 is cited as included in all three releases but that's the v19 backport PR for cranelift: Include clobbers and outgoing args in stack limit #8301, which I assume we should cite instead.
I don't feel strongly though and would be happy to see this merge as-is.
|
Thanks for the close review! Makes sense to me to apply all those changes so I've gone ahead and done so. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
That spurious failure is fixed in #8410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping
RELEASES.mdup-to-date ideally