Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double the default allowed table elements #8527

Merged
merged 2 commits into from
May 2, 2024
Merged

Double the default allowed table elements #8527

merged 2 commits into from
May 2, 2024

Conversation

alexcrichton
Copy link
Member

This commit doubles the default allowed table elements per table in the pooling allocator from 10k to 20k. This helps to, by default, run the module produced in #8504.

@alexcrichton
Double the default allowed table elements
6979f02 
This commit doubles the default allowed table elements per table in the
pooling allocator from 10k to 20k. This helps to, by default, run the
module produced in bytecodealliance#8504.
@alexcrichton alexcrichton requested a review from a team as a code owner May 2, 2024 11:40
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team May 2, 2024 11:40
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label May 2, 2024
fitzgen
fitzgen approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we document the defaults in some config.rs doc comment? Should double check and update the docs if necessary.

@alexcrichton
Copy link
Member Author

Good catch 👍

@alexcrichton alexcrichton enabled auto-merge May 2, 2024 18:06
@alexcrichton alexcrichton added this pull request to the merge queue May 2, 2024
Merged via the queue into bytecodealliance:main with commit 4fef150 May 2, 2024
21 checks passed
@alexcrichton alexcrichton deleted the double-default-elements branch May 2, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrichton @fitzgen