Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OpenBSD support to wasmtime's signals.rs #8613

Merged
merged 1 commit into from
May 14, 2024
Merged

Added OpenBSD support to wasmtime's signals.rs #8613

merged 1 commit into from
May 14, 2024

Conversation

CalebHeydon
Copy link
Contributor

This pull request adds support for OpenBSD to the wasmtime-runtime crate. The change is very small. It just adds a case for OpenBSD on x86_64. I'm not trying to port the entire project to OpenBSD. I'm just trying to get this crate to work because I am trying to get the Zed editor to run on OpenBSD.

@CalebHeydon CalebHeydon requested a review from a team as a code owner May 14, 2024 03:07
@CalebHeydon CalebHeydon requested review from elliottt and removed request for a team May 14, 2024 03:07
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label May 14, 2024
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@alexcrichton alexcrichton added this pull request to the merge queue May 14, 2024
Merged via the queue into bytecodealliance:main with commit bcc98fd May 14, 2024
22 checks passed
@fitzgen
Copy link
Member

fitzgen commented May 14, 2024

Is there not an official openbsd target in rustup? I was looking at adding a CI check to ensure that this will keep compiling in the future, and I didn't see anything. I find that a little surprising.

@cfallin
Copy link
Member

cfallin commented May 14, 2024

Unfortunately no, because OpenBSD is explicit about not guaranteeing kernel ABI stability between releases (sort of the opposite of the Linux kernel's never-break-userland rule).

In my limited explorations here, on a native OpenBSD system the package system does have Rust but it's quickly out of date; the only way to have a current Rust compiler is to run OpenBSD -CURRENT (the development branch) with its version of the package tree.

(To @CalebHeydon: at one point I got all of wasmtime building and working on OpenBSD in #2980, but abandoned the effort because keeping everything up-to-date and building given the above vs. MSRV policies was just too much work. Maybe things will change eventually!)

@lcheylus
Copy link

lcheylus commented Jun 5, 2024

@CalebHeydon Thanks for your fix to add support for OpenBSD. With it, I was able to build successfully Yara-X https://github.com/VirusTotal/yara-x :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants