cranelift: Remove nominal-sp #8643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
requested review from
abrown and
jameysharp
and removed request for
a team and
abrown
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
abrown
approved these changes
May 17, 2024
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
May 20, 2024
* Update the frame layout comment * Remove more references to nominal SP * Remove the nominal_sp_offset from backend emit states * Continue removing references to the nominal sp * Remove nominal-sp from the aarch64 backend * Remove nominal-sp from the s390x backend * Remove nominal-sp from the riscv64 backend * Remove old comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we now keep SP at the same place throughout the function body, or only modify it within the emission for individual pseudo-ops like call, we no longer need the notion of the nominal-SP. This PR removes all mentions of the nominal SP, and reworks the docs to more accurately describe the frame layout the backends currently assume.
I'm not 100% sold on the change of representation for slot offsets in the riscv64 backend, and am happy to take suggestions for a better representation than
(slot).