Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to wasm-tools 0.211.1 #8838

Merged
merged 6 commits into from
Jun 21, 2024
Merged

upgrade to wasm-tools 0.211.1 #8838

merged 6 commits into from
Jun 21, 2024

Conversation

pchickey
Copy link
Contributor

@pchickey pchickey requested a review from alexcrichton June 19, 2024 00:33
@pchickey pchickey requested review from a team as code owners June 19, 2024 00:33
@pchickey pchickey requested review from cfallin and removed request for a team June 19, 2024 00:33
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things here and there but otherwise 👍

crates/types/src/lib.rs Outdated Show resolved Hide resolved
crates/explorer/src/lib.rs Show resolved Hide resolved
crates/wasmtime/src/runtime/coredump.rs Outdated Show resolved Hide resolved
crates/wast/src/core.rs Outdated Show resolved Hide resolved
@pchickey pchickey enabled auto-merge June 19, 2024 02:18
@pchickey pchickey requested a review from a team as a code owner June 19, 2024 04:15
@pchickey pchickey requested review from elliottt and removed request for a team June 19, 2024 04:15
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:wasm fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself winch Winch issues or pull requests labels Jun 19, 2024
Copy link

Subscribe to Label Action

cc @fitzgen, @saulecabrera

This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "wasmtime:api", "winch"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing
  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@pchickey pchickey added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@alexcrichton
Copy link
Member

Ok now that's something I wasn't expecting. Changing the crate dependency graph is changing -Cmetadata to the adapter which is causing the symbols to change. For now that can be fixed by rebuilding the adapters locally but I'll try to work up a fix tomorrow to frob the name section to avoid the hashes being there.

@alexcrichton
Copy link
Member

After poking at this a bit more I think we may want to instead revert the inclusion of binaries in-tree -- #8856 -- which if that lands then this would be unblocked.

@alexcrichton alexcrichton added this pull request to the merge queue Jun 21, 2024
@alexcrichton alexcrichton removed this pull request from the merge queue due to a manual request Jun 21, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 896e25e Jun 21, 2024
38 checks passed
@alexcrichton alexcrichton deleted the pch/wasm_tools_211 branch June 21, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:wasm cranelift Issues related to the Cranelift code generator fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself winch Winch issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants