-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to wasm-tools 0.211.1 #8838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things here and there but otherwise 👍
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "wasmtime:api", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Ok now that's something I wasn't expecting. Changing the crate dependency graph is changing |
After poking at this a bit more I think we may want to instead revert the inclusion of binaries in-tree -- #8856 -- which if that lands then this would be unblocked. |
Only one change I wasn't certain of, for the
storage: &mut String
parameter in wasmprinter:https://github.com/bytecodealliance/wasmtime/compare/pch/wasm_tools_211?expand=1#diff-4863961fda2fef6610662e23fb35b7d7c2a367032798634425f2f407e0ee932aR70