Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the wasm-tools family of crates #8882

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

alexcrichton
Copy link
Member

This notably brings in a limitation where component model flags types must have 32 or fewer flags in accordance with the transition plan of WebAssembly/component-model#370. A feature flag is added to go back to the previous behavior to avoid breaking anyone too much.

This additionally brings in a fix for a panic when validating invalid modules with tail calls.

This notably brings in a limitation where component model flags types
must have 32 or fewer flags in accordance with the transition plan of
WebAssembly/component-model#370. A feature
flag is added to go back to the previous behavior to avoid breaking
anyone too much.

This additionally brings in a fix for a panic when validating invalid
modules with tail calls.
@alexcrichton
Copy link
Member Author

I'll note that this is a draft as I'd like to get in bytecodealliance/wit-bindgen#990 and bytecodealliance/wit-bindgen#989 and update wit-bindgen here too

@alexcrichton alexcrichton marked this pull request as ready for review June 28, 2024 00:15
@alexcrichton alexcrichton requested review from a team as code owners June 28, 2024 00:15
@alexcrichton alexcrichton requested review from pchickey and removed request for a team June 28, 2024 00:15
@alexcrichton
Copy link
Member Author

Ok should be reading pending CI

@alexcrichton
Copy link
Member Author

On second thought let's not update wit-bindgen.

@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Jun 28, 2024
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@alexcrichton alexcrichton added this pull request to the merge queue Jul 8, 2024
Merged via the queue into bytecodealliance:main with commit 18a6c71 Jul 8, 2024
72 checks passed
@alexcrichton alexcrichton deleted the update-wasm-tools branch July 8, 2024 13:30
alexcrichton added a commit to alexcrichton/wasmtime that referenced this pull request Jul 8, 2024
* Update the wasm-tools family of crates

This notably brings in a limitation where component model flags types
must have 32 or fewer flags in accordance with the transition plan of
WebAssembly/component-model#370. A feature
flag is added to go back to the previous behavior to avoid breaking
anyone too much.

This additionally brings in a fix for a panic when validating invalid
modules with tail calls.

* Add vet entries
alexcrichton added a commit that referenced this pull request Jul 8, 2024
* Update the wasm-tools family of crates

This notably brings in a limitation where component model flags types
must have 32 or fewer flags in accordance with the transition plan of
WebAssembly/component-model#370. A feature
flag is added to go back to the previous behavior to avoid breaking
anyone too much.

This additionally brings in a fix for a panic when validating invalid
modules with tail calls.

* Add vet entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants