Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature combinations in testing #9016

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

iawia002
Copy link
Contributor

I reencountered the issue of feature combinations in this CI, similar to #8997:

error[E0277]: the trait bound `cranelift_codegen::ir::GlobalValue: Serialize` is not satisfied
    --> cranelift/wasm/src/heap.rs:67:12
     |
67   |     derive(serde_derive::Serialize, serde_derive::Deserialize)
     |            ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Serialize` is not implemented for `cranelift_codegen::ir::GlobalValue`

cc @alexcrichton

@iawia002 iawia002 requested a review from a team as a code owner July 26, 2024 04:36
@iawia002 iawia002 requested review from abrown and removed request for a team July 26, 2024 04:36
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:wasm labels Jul 26, 2024
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Jul 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Jul 26, 2024
Merged via the queue into bytecodealliance:main with commit 3e97612 Jul 26, 2024
37 checks passed
@iawia002 iawia002 deleted the feature branch July 26, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:wasm cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants