Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -Wunknown-imports-trap to components #9021

Merged

Conversation

alexcrichton
Copy link
Member

This was implemented in #8672 and is an easy addition to the CLI.

Closes #9019

This was implemented in bytecodealliance#8672 and is an easy addition to the CLI.

Closes bytecodealliance#9019
@alexcrichton alexcrichton requested a review from a team as a code owner July 26, 2024 15:21
@alexcrichton alexcrichton requested review from elliottt and removed request for a team July 26, 2024 15:21
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@alexcrichton alexcrichton enabled auto-merge July 26, 2024 15:39
@alexcrichton alexcrichton added this pull request to the merge queue Jul 26, 2024
Merged via the queue into bytecodealliance:main with commit 57049dd Jul 26, 2024
37 checks passed
@alexcrichton alexcrichton deleted the component-trapping-imports branch July 26, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make define_unknown_imports_as_traps available in CLI
2 participants