Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat undeclared maximum as 4GiB #944

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

pepyakin
Copy link
Contributor

This change allows memories with an undeclared maximum to leverage static-style memory on 64-bit machines.

@pepyakin pepyakin requested a review from sunfishcode February 13, 2020 13:49
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Just a few minor nits below:

crates/environ/src/module.rs Outdated Show resolved Hide resolved
crates/environ/src/module.rs Outdated Show resolved Hide resolved
@alexcrichton alexcrichton merged commit c94cdc7 into bytecodealliance:master Feb 18, 2020
@pepyakin pepyakin deleted the static-mem-if-possible branch February 18, 2020 15:38
arkpar pushed a commit to paritytech/wasmtime that referenced this pull request Mar 4, 2020
Enables automated fuzzing on Fuzzit. Runs fuzz regression tests
every push and PR. Runs full fuzzing every push. Fuzzit emails
if it finds crashes.

Uses the existing fuzz targets:
* translate-module - Fuzz valid WebAssembly modules.
* reader-parse - Fuzz IR text format parsing.
arkpar pushed a commit to paritytech/wasmtime that referenced this pull request Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants