Pin some runner images #9717
Merged
Pin some runner images #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the larger test/build jobs use some variables in the `*.js` files calculating the matrix to pin the images to fixed versions of GitHub actions images. For the `main.yml` file instead of changing everything over to a pin only do the ones that are currently failing on the `ubuntu-24.04` update. The hope is that there's only a few locations to update pinned versions in the future, and we'll need to keep an eye on CI warnings and such to know when to update these pins in the future.
|
(result of learnings from #9715) |
|
For some longer-form rationale, my thinking here is it's not an unreasonable default to stick to |
cfallin
approved these changes
Dec 4, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Dec 4, 2024
Manually updating some images after the pinning in bytecodealliance#9717. There's a few more images after this but this should be the lion's share of the update. prtest:full
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Manually updating some images after the pinning in #9717. There's a few more images after this but this should be the lion's share of the update. prtest:full
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the larger test/build jobs use some variables in the
*.jsfiles calculating the matrix to pin the images to fixed versions of GitHub actions images. For themain.ymlfile instead of changing everything over to a pin only do the ones that are currently failing on theubuntu-24.04update. The hope is that there's only a few locations to update pinned versions in the future, and we'll need to keep an eye on CI warnings and such to know when to update these pins in the future.