fix(tiny-go): fix generated code in type_flags function (#911)

* add testcase for when flags have dashes Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com> * fix(tiny-go): fix generated code in type_flags function Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com> --------- Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
bytecodealliance · Mar 28, 2024 · ed26dbf · ed26dbf
1 parent b4b56c0
commit ed26dbf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/crates/go/src/interface.rs b/crates/go/src/interface.rs
@@ -1179,17 +1179,19 @@ impl<'a> wit_bindgen_core::InterfaceGenerator<'a> for InterfaceGenerator<'a> {
         self.src.push_str(&format!("type {name} uint64\n"));
         self.src.push_str("const (\n");
         for (i, flag) in flags.flags.iter().enumerate() {
+            let case_flag = flag.name.to_upper_camel_case();
+
             if i == 0 {
                 self.src.push_str(&format!(
                     "   {name}_{flag} {name} = 1 << iota\n",
                     name = name,
-                    flag = flag.name.to_uppercase(),
+                    flag = case_flag,
                 ));
             } else {
                 self.src.push_str(&format!(
                     "   {name}_{flag}\n",
                     name = name,
-                    flag = flag.name.to_uppercase(),
+                    flag = case_flag,
                 ));
             }
         }

diff --git a/tests/codegen/flags.wit b/tests/codegen/flags.wit
@@ -40,6 +40,10 @@ interface %flags {
     b56, b57, b58, b59, b60, b61, b62, b63,
   }
 
+  flags withdashes {
+    with-dashes,
+  }
+
   roundtrip-flag1: func(x: flag1) -> flag1;
   roundtrip-flag2: func(x: flag2) -> flag2;
   roundtrip-flag4: func(x: flag4) -> flag4;