Correctly derive Clone on generated types (#184)

* Added a failing test * Implement clone where possible * Arguments can't be called "i"
bytecodealliance · Apr 1, 2022 · f5eed0f · f5eed0f
1 parent 01231ec
commit f5eed0f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/gen-rust/src/lib.rs b/crates/gen-rust/src/lib.rs
@@ -538,6 +538,8 @@ pub trait RustGenerator {
                 // skip copy/clone
             } else if !info.owns_data() {
                 self.push_str("#[derive(Clone, Copy)]\n");
+            } else if !info.has_handle {
+                self.push_str("#[derive(Clone)]\n");
             }
             self.push_str(&format!("pub enum {}", name.to_camel_case()));
             self.print_generics(&info, lt, true);

diff --git a/tests/codegen/variants.wit b/tests/codegen/variants.wit
@@ -126,3 +126,10 @@ return-option-sugar: function() -> option<s32>
 return-option-sugar2: function() -> option<my-errno>
 
 expected-simple: function() -> expected<u32, s32>
+
+record is-clone {
+  v1: v1,
+}
+
+is-clone-arg: function(a: is-clone)
+is-clone-return: function() -> is-clone