Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WIT.md to use func keyword instead of function #236

Closed
eyebrowsoffire opened this issue Jun 10, 2022 · 3 comments
Closed

Update WIT.md to use func keyword instead of function #236

eyebrowsoffire opened this issue Jun 10, 2022 · 3 comments

Comments

@eyebrowsoffire
Copy link
Contributor

I have been familiarizing myself with the .wit format, and playing around with it in the online bindings generator. One thing I noticed is that the WIT.md grammar and examples all use the keyword function, but that doesn't actually work in the bindings generator, it uses the keyword func. I'm not sure if the documentation is out of date and the implementation is correct, or the other way around, but it would be good if these two things matched up.

@peterhuene
Copy link
Member

It just changed to func very recently, so there's probably places where we failed to update the examples. If you spot any, we'd happily take a PR!

@eyebrowsoffire
Copy link
Contributor Author

Oh it actually just updated. I was using a newer version of the online bindings generator but reading a version of WIT.md from yesterday! That being said, I did find that the grammar itself uses the wrong string, so I did open a PR: #238

@peterhuene
Copy link
Member

Thanks again for putting up a fix for this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants