Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grammar for func in WIT.md #238

Merged
merged 3 commits into from
Jun 11, 2022
Merged

Update grammar for func in WIT.md #238

merged 3 commits into from
Jun 11, 2022

Conversation

eyebrowsoffire
Copy link
Contributor

Just a documentation update for some instances of function that should be replaced with func.

#236

@eyebrowsoffire eyebrowsoffire mentioned this pull request Jun 10, 2022
Closed
@peterhuene
Copy link
Member

@eyebrowsoffire thanks for the PR.

I did notice from the error message in #237 that it errors with fn instead of func. Would you mind including an update to that string as part of this PR?

@peterhuene peterhuene mentioned this pull request Jun 10, 2022
Closed
peterhuene
peterhuene approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks again! Will merge when CI is green.

@eyebrowsoffire
Copy link
Contributor Author

Awesome! Thanks for the quick review.

@peterhuene peterhuene merged commit de91e00 into bytecodealliance:main Jun 11, 2022
@eyebrowsoffire eyebrowsoffire deleted the funcupdate branch June 11, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhuene peterhuene peterhuene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyebrowsoffire @peterhuene