Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] minor improvement to reduce unused using statements #1070

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[C#] minor improvement to reduce unused using statements #1070

merged 3 commits into from
Nov 19, 2024

Conversation

yowl
Copy link
Collaborator

@yowl yowl commented Oct 27, 2024

No description provided.

@jsturtevant
Copy link
Collaborator

nice! This has been on the list under #713 "fix imports so they are only included if needed"

@yowl
Copy link
Collaborator Author

yowl commented Oct 28, 2024

There's more 2 do here, but its a start.

@yowl yowl marked this pull request as ready for review October 28, 2024 17:19
jsturtevant
jsturtevant reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem the tests are passing. Is there more to do?

crates/csharp/src/lib.rs Outdated Show resolved Hide resolved
@jsturtevant jsturtevant mentioned this pull request Nov 6, 2024
Closed
@yowl yowl mentioned this pull request Nov 7, 2024
Merged
silesmo
silesmo approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@silesmo silesmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@silesmo silesmo added this pull request to the merge queue Nov 19, 2024
Merged via the queue into bytecodealliance:main with commit 1739caf Nov 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@silesmo silesmo silesmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yowl @jsturtevant @silesmo