Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Lowercase OCI reference before pushing #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joonas
Copy link

@joonas joonas commented Dec 6, 2024

Motivated by bytecodealliance/wasm-pkg-tools#134.

This uses bash parameter expansion with the ,, operator to lowercase the entire input.

Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
@yoshuawuyts
Copy link
Member

thank you for filing this! I'm wondering though: is this the right place to fix this? Shouldn't we fix this in wkg instead?

@joonas
Copy link
Author

joonas commented Dec 6, 2024

I don't know if it's appropriate to roll this into wkg itself due to the fact that it might be getting used against non-conformant registries (i.e. ones that do allow for uppercase letters), and it might be surprising to have wkg lowercase the name automatically for you there (though maybe it should be behind a flag? not sure).

I suppose the same could be said for this action, but it seemed like a more appropriate place to have this logic since the likelihood of this being used against ghcr.io or other OCI conformant registries is much higher, and having those pushes fail due to uppercase letters is rather unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants