Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic fault discovery for cpython #642

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

cnguoyj-leminis
Copy link
Collaborator

1.Fix the issue of incorrect PID in the reporting message;
2.Implement automatic fault discovery functionality for cpython using signals

A similar PR may already be submitted!
Please search among the Pull request before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

For more information, see the CONTRIBUTING guide.

Summary

This PR fixes/implements the following bugs/features

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Code formatting

Closing issues

Fixes #

2.Implement automatic fault discovery functionality using signals
@cnguoyj-leminis cnguoyj-leminis requested a review from yoloyyh June 25, 2024 03:42
@cnguoyj-leminis cnguoyj-leminis merged commit da57ec8 into memshell-main Jul 1, 2024
INIT_FUNCTION(probe) {
if (!gProbe)
INIT_RETURN(nullptr);

signal(SIGTERM, signal_handler); // 15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些信号处理函数,对于子进程能生效吗?

return ;
}

ClassFilter classFilter = new ClassFilter();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分已经封装了API,可以直接调用sendMetadataObject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants