-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invalid pcsp in x86_64 #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuq19
force-pushed
the
fix/pcsp
branch
4 times, most recently
from
June 6, 2024 09:08
0652fa6
to
2a49e8a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
- Coverage 77.56% 71.21% -6.35%
==========================================
Files 83 130 +47
Lines 11542 8363 -3179
==========================================
- Hits 8952 5956 -2996
+ Misses 2192 2084 -108
+ Partials 398 323 -75 ☔ View full report in Codecov by Sentry. |
liuq19
force-pushed
the
fix/pcsp
branch
12 times, most recently
from
June 12, 2024 07:44
d8701d8
to
38178a6
Compare
AsterDY
approved these changes
Jun 12, 2024
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go-contrib
Jun 20, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/bytedance/sonic](https://github.com/bytedance/sonic) | `v1.11.8` -> `v1.11.9` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fbytedance%2fsonic/v1.11.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fbytedance%2fsonic/v1.11.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fbytedance%2fsonic/v1.11.8/v1.11.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fbytedance%2fsonic/v1.11.8/v1.11.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bytedance/sonic (github.com/bytedance/sonic)</summary> ### [`v1.11.9`](https://github.com/bytedance/sonic/releases/tag/v1.11.9) [Compare Source](https://github.com/bytedance/sonic/compare/v1.11.8...v1.11.9) ##### What's Changed - chore: remove noavx2 mode by [@​liuq19](https://github.com/liuq19) in [https://github.com/bytedance/sonic/pull/647](https://github.com/bytedance/sonic/pull/647) - fix: invalid pcsp in x86\_64 by [@​liuq19](https://github.com/liuq19) in [https://github.com/bytedance/sonic/pull/644](https://github.com/bytedance/sonic/pull/644) - fix(visitor): unconsumed rbrace in (\*traverser).decodeObject() by [@​zhongxinghong](https://github.com/zhongxinghong) in [https://github.com/bytedance/sonic/pull/654](https://github.com/bytedance/sonic/pull/654) **Full Changelog**: bytedance/sonic@v1.11.8...v1.11.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some details:
For calculate PCSP:
call
,ret
,subq imm, %rsp
,addq imm, %rsp
,leaq imm(%rbp), %rsp
andq imm, %rsp
, because of the lack of an exact deltaFor test PCSP:
0xcc
instruction) as a mock function, and each0xcc
will cause traptestSigtrap
function in golang runtime to test backtrace in each trap instructionRelated PR in asm2asm tool is cloudwego/asm2asm#5