Adding preset for leapmotion controller #1056
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junlarsen
reviewed
Jun 21, 2021
There was a problem hiding this comment.
Looks good so far. Just a few nits and a couple things to add:
- JavaCPP is built and distributed in CI, meaning there should be a new
.github/workflows/leapmotion.ymlworkflow. You can copy one of the existing workflows and go from there. It's usually just a matter of changing a few names.- Because the user has to download leapmotion themselves, we also need to do this in CI. You should download leapmotion in the action files found in
.github/actionsfor the platforms your preset is available for. - Testing this is easily done by re-targeting the workflow's branch against your own fork.
- Because the user has to download leapmotion themselves, we also need to do this in CI. You should download leapmotion in the action files found in
- The license for leapmotion should be copied into the preset's directory.
Comment on lines
+28
to
+69
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>${javacpp.moduleId}</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>${javacpp.platform.android-arm}</classifier> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>${javacpp.moduleId}</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>${javacpp.platform.android-arm64}</classifier> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>${javacpp.moduleId}</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>${javacpp.platform.android-x86}</classifier> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>${javacpp.moduleId}</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>${javacpp.platform.android-x86_64}</classifier> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>${javacpp.moduleId}</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>${javacpp.platform.linux-x86}</classifier> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>${javacpp.moduleId}</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>${javacpp.platform.linux-x86_64}</classifier> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>${javacpp.moduleId}</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>${javacpp.platform.macosx-x86_64}</classifier> | ||
| </dependency> |
There was a problem hiding this comment.
Judging from the current cppbuild.sh we're currently building windows-x86_64 and windows-x86. The other platforms which are not supported yet should be removed from the dependency list.
Comment on lines
+139
to
+145
| requires static org.bytedeco.${javacpp.moduleId}.android.arm; | ||
| requires static org.bytedeco.${javacpp.moduleId}.android.arm64; | ||
| requires static org.bytedeco.${javacpp.moduleId}.android.x86; | ||
| requires static org.bytedeco.${javacpp.moduleId}.android.x86_64; | ||
| requires static org.bytedeco.${javacpp.moduleId}.linux.x86; | ||
| requires static org.bytedeco.${javacpp.moduleId}.linux.x86_64; | ||
| requires static org.bytedeco.${javacpp.moduleId}.macosx.x86_64; |
There was a problem hiding this comment.
Similarly to how we're only adding dependencies for existing platforms, we only want the available platforms listed here. These entries should be removed until more platforms are added.
| =============================== | ||
|
|
||
| [](https://gitter.im/bytedeco/javacpp) [](https://maven-badges.herokuapp.com/maven-central/org.bytedeco/leapmotion) [](http://bytedeco.org/builds/) | ||
| <sup>Build status for all platforms:</sup> [](https://github.com/bytedeco/javacpp-presets/actions?query=workflow%3Aleapmotion) <sup>Commercial support:</sup> [](https://xscode.com/bytedeco/javacpp-presets) |
There was a problem hiding this comment.
We should also add the workflow status badge to the main README.md as well as listing leapmotion as one of the available presets.
| @@ -630,6 +630,7 @@ | |||
| <module>cpu_features</module> | |||
| <module>modsecurity</module> | |||
| <module>systems</module> | |||
| <module>leapmotion</module> | |||
There was a problem hiding this comment.
Leapmotion should also be registered as an available module for the platforms you're building. Each JavaCPP platform has its own profile in this pom and leapmotion should be registered in these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.