-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to ffmpeg 5.0 #1125
update to ffmpeg 5.0 #1125
Conversation
It looks like autoreconf is broken in the new Windows image of GitHub Actions. |
ffmpeg/README.md
Outdated
@@ -1,36 +1,38 @@ | |||
# JavaCPP Presets for FFmpeg | |||
JavaCPP Presets for FFmpeg | |||
========================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would ask that these markdown changes not be reverted. They show up as red squiggle errors in my editor (i.e. fail markdown linting).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason to make it inconsistent with the other README.md files. If there's a good reason to change it though, we'll do it for all of them, and that's going to be for another pull request if you want to do that. However, maybe it's just your linting tool that's buggy. How do you know that's not the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tool is reporting valid violations of these rules:
https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md#md003---header-style
I accept that could be a different commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's do that in different commits, for the other repositories too!
BTW, it doesn't appear to violate setext_with_atx, that looks alright. The reason I do it that way is that it looks better with setext, but there aren't any for level 3. I guess I'm not the only one to feel that way.
So, this looks good to merge? We can work on the markdown and issue #1099 later and open more pull requests for that. |
No description provided.