Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPC/SHM to systems #1132

Merged
merged 10 commits into from
Jan 23, 2022
Merged

Add IPC/SHM to systems #1132

merged 10 commits into from
Jan 23, 2022

Conversation

wmeddie
Copy link
Contributor

@wmeddie wmeddie commented Jan 22, 2022

Adds shmget and related functions to linux and maxosx.

@saudet
Copy link
Member

saudet commented Jan 23, 2022

Looks good to me! OK to merge?

@saudet saudet marked this pull request as ready for review January 23, 2022 02:09
@wmeddie
Copy link
Contributor Author

wmeddie commented Jan 23, 2022

Do we need to add any tests?

@saudet
Copy link
Member

saudet commented Jan 23, 2022

Nah, just that it compiles is good enough. I run the samples manually before releases to make sure loading works, and that's enough. That reminds me @matsjla is supposed to be working on automating that as part of the Maven build. Any updates?

@wmeddie
Copy link
Contributor Author

wmeddie commented Jan 23, 2022

I see. If so then it is ready to go from my side.

@saudet saudet merged commit da8c22a into bytedeco:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants