-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create no GPU build for Tritonserver #1151
Conversation
Looks good, but how different is this from pull #1146? |
This adds a build section that's specifically for building the |
Ok, I see. Now, BTW, currently there are also |
Does this current addition to the platform code make sense?
Triton library is 21MB by itself... does that mean in the redist jar file squeezed everything down to 6MB, including library and bindings? I think we can probably remove the redist folder. Lets see what @jackyh thinks |
Yes, looking good! Thanks
Yes, it's 21 MB uncompressed, for example, look inside this JAR file: |
I've updated the samples/pom.xml file to use that shaded artifact. This looks good to merge for now, so we can decide later what to do with the redist artifact, if that's OK? |
Thanks for making the changes Samuel! Happy to have it merged. We can chat about redist later |
As the current common use case is for CPU-only builds, change javacpp-presets dependencies to reflect that